Skip to content

Polish SongForge structure and exports#56

Merged
WalksWithASwagger merged 1 commit into
mainfrom
codex/issue-52-songforge-polish
May 22, 2026
Merged

Polish SongForge structure and exports#56
WalksWithASwagger merged 1 commit into
mainfrom
codex/issue-52-songforge-polish

Conversation

@WalksWithASwagger
Copy link
Copy Markdown
Owner

Summary

  • Add deterministic structure variants and originality guardrails to SongForge packs.
  • Render guardrails, structure variants, prompt packs, and source notes cleanly in markdown/vault exports.
  • Update fixture evals and presentation docs to keep SongForge positioned as source-linked text workflow, not direct music generation.

Verification

  • PYTHON=/Users/kk/Code/spektorAI/venv/bin/python make lint
  • PYTHON=/Users/kk/Code/spektorAI/venv/bin/python make test -> 283 passed
  • PYTHON=/Users/kk/Code/spektorAI/venv/bin/python make eval-fixture
  • git diff --check

Closes #52

@github-actions
Copy link
Copy Markdown

Agentic PR Review

Verdict: needs-human

Checks:

  • Linked issue via Closes #...: yes
  • Issue acceptance criteria found: 4
  • PR verification section present: yes
  • PR acceptance self-check present: no
  • PR self-check covers issue acceptance: no
  • Diff within v1 limits: yes
  • Missing acceptance coverage:
    • SongForge emits multiple structure variants with source notes and originality guardrails.
    • Markdown/vault exports preserve lyric, spoken-word, prompt-pack, and source-note sections cleanly.
    • Presentation docs describe SongForge as a source-linked text workflow, not direct music generation.
    • Fixture tests pin the output structure.

This PR is not blocked from human review, but the agentic gate is not satisfied.

@github-actions github-actions Bot added the needs-human Agentic automation stopped for human judgment. label May 22, 2026
@WalksWithASwagger WalksWithASwagger merged commit 8f3e83a into main May 22, 2026
1 check passed
@WalksWithASwagger WalksWithASwagger deleted the codex/issue-52-songforge-polish branch May 22, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-human Agentic automation stopped for human judgment.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve SongForge creative quality and exports

1 participant