This repository was archived by the owner on Sep 26, 2025. It is now read-only.
feat: notification metadata#1503
Draft
chris13524 wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
devceline
reviewed
Mar 21, 2024
| // The body of the notification | ||
| body: string | ||
| id: string | ||
| // A call-to-action URL for when clicking on the notification |
Contributor
There was a problem hiding this comment.
We don't really control the UX of how they use the URL though
Member
Author
There was a problem hiding this comment.
Yeah I guess I was overly prescriptive. But I wanted to explain what it was intended for more than just "a URL". Do you have a suggestion for better description?
devceline
approved these changes
Mar 21, 2024
glitch-txs
approved these changes
Mar 21, 2024
3 tasks
glitch-txs
approved these changes
May 18, 2024
glitch-txs
left a comment
glitch-txs
left a comment
Contributor
There was a problem hiding this comment.
can we merge this? @chris13524 @devceline
Member
Author
@glitch-txs no because Web3Inbox client doesn't yet support: https://linear.app/walletconnect/issue/W3I-80/custom-notification-metadata-%5Bclient%5D |
glitch-txs
suggested changes
Jun 5, 2024
glitch-txs
left a comment
glitch-txs
left a comment
Contributor
There was a problem hiding this comment.
The structure changed under AppKit/WalletKit
chris13524
marked this pull request as draft
July 30, 2024 17:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document support for custom notification metadata
Blocked by client support: https://linear.app/walletconnect/issue/W3I-80/custom-notification-metadata-%5Bclient%5D