feat: redundant storage#13
Open
Le0Developer wants to merge 8 commits into
Open
Conversation
WalshyDev
reviewed
Nov 5, 2023
WalshyDev
left a comment
WalshyDev
left a comment
Owner
There was a problem hiding this comment.
ty! I was planning to do these changes as well so appreciate this
| ``` | ||
|
|
||
| To setup D1, you need to run the following SQL statement: | ||
| `CREATE TABLE IF NOT EXISTS KV (key TEXT UNIQUE, value TEXT)` |
Owner
There was a problem hiding this comment.
Suggested change
| `CREATE TABLE IF NOT EXISTS KV (key TEXT UNIQUE, value TEXT)` | |
| `CREATE TABLE IF NOT EXISTS incidents (key TEXT UNIQUE, value JSON)` |
Contributor
Author
There was a problem hiding this comment.
This is SQLite, JSON will actually be mapped to NUMERIC.
See datatype3 3.1:
- If the declared type contains the string "INT" then it is assigned INTEGER affinity.
- If the declared type of the column contains any of the strings "CHAR", "CLOB", or "TEXT" then that column has TEXT affinity. Notice that the type VARCHAR contains the string "CHAR" and is thus assigned TEXT affinity.
- If the declared type for a column contains the string "BLOB" or if no type is specified then the column has affinity BLOB.
- If the declared type for a column contains any of the strings "REAL", "FLOA", or "DOUB" then the column has REAL affinity.
- Otherwise, the affinity is NUMERIC.
| env.KV && env.KV.put(key, data), | ||
| env.D1 && | ||
| env.D1.prepare( | ||
| `INSERT INTO KV(key, value) VALUES(?1, ?2) ON CONFLICT(key) DO UPDATE SET value = ?2`, |
Owner
There was a problem hiding this comment.
Suggested change
| `INSERT INTO KV(key, value) VALUES(?1, ?2) ON CONFLICT(key) DO UPDATE SET value = ?2`, | |
| `INSERT INTO incidents(key, value) VALUES(?1, ?2) ON CONFLICT(key) DO UPDATE SET value = ?2`, |
| const rawValues = await Promise.allSettled([ | ||
| env.KV && env.KV.get(key), | ||
| env.D1 && | ||
| env.D1.prepare(`SELECT value FROM KV WHERE key = ?`).bind(key).first("value"), |
Owner
There was a problem hiding this comment.
Suggested change
| env.D1.prepare(`SELECT value FROM KV WHERE key = ?`).bind(key).first("value"), | |
| env.D1.prepare(`SELECT value FROM incidents WHERE key = ?`).bind(key).first("value"), |
Co-authored-by: Daniel Walsh <walshydev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KV can go down. So lets also use D1 and R2.
Note: I didn't test thisI have tested this