fix(core): score empty traces as incomplete#22
Open
JSap0914 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #19.
computeTraceCompleteness()treated an empty event array as fully complete by returning100. That made an empty or failed trace look partially audited instead of marking trace completeness as missing.This changes the empty-trace branch to return
0and adds a regression test throughcomputeRiskScore().Verification
bun test packages/core/src/scoring/index.test.ts -t "returns zero trace completeness"failed withExpected: 0,Received: 100.bun test packages/core/src/scoring/index.test.ts-> 16 pass.bun -e "import { computeRiskScore } from './packages/core/src/scoring/index.ts'; const score = await computeRiskScore([], 'empty-run'); console.log(JSON.stringify({run_id: score.run_id, trace_completeness: score.components.trace_completeness, evidence_admission_score: score.evidence_admission_score.score}));"->{"run_id":"empty-run","trace_completeness":0,"evidence_admission_score":50}.git diff --checkpassed.Notes
I also ran broader local checks after building
packages/schema:bun run --cwd packages/core teststill has two unrelated failures inpolicy-auditandreporttests.bun run --cwd packages/core typecheckstill fails on pre-existingbun:testtype resolution and unrelated implicit-any diagnostics.bun run lintreports existing repository-wide Biome formatting/lint drift.