fix(aep): Date.now() timestamps + addAction capability_decision sync#17
Merged
Merged
Conversation
…on sync Two fixes in AEPEmitter: 1. Replace performance.now() with Date.now() for all default timestamps. performance.now() returns ms-since-process-start (~730ms), not Unix epoch, causing downstream tools to show 1970-01-01 for all records. (#14) 2. addAction() with capability_decision now auto-registers to the record-level capability_decisions[] array (deduped by capability+subject+resource). Previously the split API caused silent empty manifests. (#15) Fixes #14 Fixes #15 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
performance.now()withDate.now()inemit(),build(), andaddAction().performance.now()returns ms-since-process-start (~730), not Unix epoch — downstream tools showed1970-01-01for all records.addAction()withcapability_decisionnow auto-registers to record-levelcapability_decisions[](deduped by capability+subject+resource). Previously the split API causedtoEvents()to produce zeropolicy_decisionevents.Test plan
emit()without explicit timestamp producescreated_at_msin reasonable epoch range (e.g. >1700000000000)addAction({ capability_decision: {...} })populatescapability_decisions[]without separateaddCapabilityDecision()callFixes #14, #15
🤖 Generated with Claude Code