-
-
Notifications
You must be signed in to change notification settings - Fork 83
Sync Dev to Main #1187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Sync Dev to Main #1187
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
2a9cbbf
fix: battle/raid filtering race condition
Mygod cd01a92
fix: ground raid/battle icons
Mygod 3717c2e
chore: centralize overlay logic
Mygod 21b50f5
fix: weather icon in pokemon background popup
Mygod 640c5ad
chore(release): v1.40.2-develop.1 [skip ci]
semantic-release-bot 4f5aace
feat: support stationed pokemon extras
Mygod 907ca33
fix: no scrollbars plz
Mygod 8a0447c
feat: dynamic placed Pokemon dropdown height
Mygod 497f350
fix: battle/raid icon max height
Mygod b2ea525
chore(release): v1.41.0-develop.1 [skip ci]
semantic-release-bot 0f157ed
fix: remove extra Forms
Mygod e46ea5b
chore(release): v1.41.0-develop.2 [skip ci]
semantic-release-bot a2c7f17
fix: logic bug in loading non-clustered elements (#1161)
ComplementaryPogo bce4be5
chore: sync config [skip ci]
turtlesocks-bot d3ea283
feat: default clientPrompt to none to skip permission reapproval
Mygod d7ecbde
chore: sync config [skip ci]
turtlesocks-bot b579ded
fix: more robust discord handling (#1181)
Mygod 11c75e0
chore(release): v1.41.0-develop.3 [skip ci]
semantic-release-bot cea3141
fix: area reload
Mygod 5c907c5
chore(release): v1.41.0-develop.4 [skip ci]
semantic-release-bot 7bd5ce1
fix: escape gpx xml (#1186)
josh-vin 5b32067
chore(release): v1.41.0-develop.5 [skip ci]
semantic-release-bot 8adba28
feat: ar/no-ar quest dot badge
Mygod b626d3d
fix: showcase icons display
Mygod 4b73e0e
chore: sync config [skip ci]
turtlesocks-bot d418fed
chore(deps): bump lodash-es from 4.17.21 to 4.17.23 (#1188)
dependabot[bot] f9f05d9
chore(deps): bump @apollo/server from 4.11.0 to 5.4.0 (#1190)
dependabot[bot] 6b9eb0c
chore(deps): bump lodash from 4.17.21 to 4.17.23 (#1189)
dependabot[bot] ce37e2a
fix: im dumdum
Mygod a106233
chore(release): v1.41.0-develop.6 [skip ci]
semantic-release-bot 3907656
fix: properly migrate to express 5
Mygod 55ba38a
chore(release): v1.41.0-develop.7 [skip ci]
semantic-release-bot 018ba93
fix: hidden power in raids are fighting type
Mygod 12f0012
chore(release): v1.41.0-develop.8 [skip ci]
semantic-release-bot ee176da
fix: pokemon onlyManualId filter in expert sql mode
Mygod dfda729
chore(release): v1.41.0-develop.9 [skip ci]
semantic-release-bot 647a175
fix: ditto shenanigans (#1193)
Mygod a4d5d85
chore(release): v1.41.0-develop.10 [skip ci]
semantic-release-bot 09633ec
chore(deps): bump rollup from 4.48.1 to 4.59.0 (#1192)
dependabot[bot] 8640ee0
fix: sentry node version
Mygod 6b8545c
chore(release): v1.41.0-develop.11 [skip ci]
semantic-release-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 26702 | ||
| 26772 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| const DITTO_ID = 132 | ||
|
|
||
| const normalizePokemonId = (pokemonId) => { | ||
| const parsedPokemonId = Number.parseInt(`${pokemonId}`, 10) | ||
| return Number.isNaN(parsedPokemonId) ? 0 : parsedPokemonId | ||
| } | ||
|
|
||
| const normalizePokemonForm = (pokemonId, formId = 0) => { | ||
| if (normalizePokemonId(pokemonId) === DITTO_ID) { | ||
| // Confirmed wild Ditto is already treated as species-based upstream. | ||
| // Golbat/MEM keeps the scanner lookup on `pokemon_id = 132, form = 0`, | ||
| // while the raw form field may still carry the disguise form for display. | ||
| return 0 | ||
| } | ||
| const parsedFormId = Number.parseInt(`${formId ?? 0}`, 10) | ||
| return Number.isNaN(parsedFormId) ? 0 : parsedFormId | ||
| } | ||
|
|
||
| const getWildFilterKey = (pokemonId, formId = 0) => | ||
| `${normalizePokemonId(pokemonId)}-${normalizePokemonForm(pokemonId, formId)}` | ||
|
|
||
| module.exports = { | ||
| DITTO_ID, | ||
| getWildFilterKey, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.