[spec] Syntax for descriptor types#99
Merged
Merged
Conversation
Add syntax descriptor types (i.e. "desctypes"), which prefix a comptype with optional describes and descriptor clauses. Update sub type to contain a desctype instead of a comptype. Add a Dectype_ok rule and a placeholder Desctype_sub rule, but leave the full matching rules to a future change because they are rather complicated. Update the document to splice in the new rules and update the macro definitions so they render correctly.
Member
Author
|
This still needs some work. |
rossberg
reviewed
Apr 15, 2026
rossberg
left a comment
rossberg
left a comment
Member
There was a problem hiding this comment.
Looks good so far, mostly nits.
Comment on lines
+119
to
+120
| syntax describes hint(show DESCRIBES %) hint(macro "%" "T%") = DESCRIBES typeuse | ||
| syntax descriptor hint(show DESCRIPTOR %) hint(macro "%" "T%") = DESCRIPTOR typeuse |
Member
There was a problem hiding this comment.
These show hints are redundant.
|
|
||
| syntax desctype hint(desc "descriptor type") = | ||
| | describes? descriptor? comptype | ||
| hint(show % % %) |
Comment on lines
+409
to
+410
| def $subst_describes(DESCRIBES tu, tv*, tu*) = DESCRIBES $subst_typeuse(tu, tv*, tu*) | ||
| def $subst_descriptor(DESCRIPTOR tu, tv*, tu*) = DESCRIPTOR $subst_typeuse(tu, tv*, tu*) |
| def $free_descriptor(DESCRIPTOR tu) = $free_typeuse(tu) | ||
|
|
||
| def $free_desctype(dc1? dc2? ct) = | ||
| $free_list($free_describes(dc1)?) ++ $free_list($free_descriptor(dc2)?) ++ $free_comptype(ct) |
Member
There was a problem hiding this comment.
Nit:
Suggested change
| $free_list($free_describes(dc1)?) ++ $free_list($free_descriptor(dc2)?) ++ $free_comptype(ct) | |
| $free_opt($free_describes(dc1)?) ++ $free_opt($free_descriptor(dc2)?) ++ $free_comptype(ct) |
Comment on lines
+156
to
+162
| C |- SUB FINAL? (_IDX x)* dct : OK(x_0) | ||
| -- if |x*| <= 1 | ||
| -- (if x < x_0)* | ||
| -- (if $unrolldt(C.TYPES[x]) = SUB (_IDX x')* comptype')* | ||
| -- (if $unrolldt(C.TYPES[x]) = SUB (_IDX x')* dct')* | ||
| ---- | ||
| -- Comptype_ok: C |- comptype : OK | ||
| -- (Comptype_sub: C |- comptype <: comptype')* | ||
| -- Desctype_ok: C |- dct : OK | ||
| -- (Desctype_sub: C |- dct <: dct')* |
Member
There was a problem hiding this comment.
Nit: s/dct/desctype/g, for consistency with below
Member
Author
|
@rossberg, please take another look. I've addressed your comments and added new content and splices to the .rst files. |
rossberg
approved these changes
Jun 27, 2026
Comment on lines
+119
to
+120
| syntax describes hint(macro "T%" "T%") = DESCRIBES | ||
| syntax descriptor hint(macro "T%" "T%") = DESCRIPTOR |
Member
There was a problem hiding this comment.
These extra definitions seem odd, what's the reason? I think you should be able to inline them.
Member
Author
There was a problem hiding this comment.
I was able to inline them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add syntax for descriptor types (i.e. "desctypes"), which prefix a comptype with optional describes and descriptor clauses. Update sub type to contain a desctype instead of a comptype. Add a Desctype_ok rule and a placeholder Desctype_sub rule, but leave the full matching rules to a future change because they are rather complicated. Update the document to splice in the new rules and update the macro definitions so they render correctly.