PR: Add Bulk WP menu at network level#673
Open
esudalaimadan wants to merge 11 commits intodev/6.2.0from
Open
Conversation
Repository owner
deleted a comment
Sep 25, 2019
Repository owner
deleted a comment
Oct 1, 2019
Apply fixes from StyleCI
Repository owner
deleted a comment
Oct 2, 2019
Repository owner
deleted a comment
Oct 2, 2019
Contributor
Author
|
https://github.com/sudar/bulk-delete/blob/671-feature/add-mutisite-support-for-users-module/tests/wp-unit/include/Core/Users/Modules/DeleteUsersByUserMetaInMultisiteModuleTest.php is failing for single site though I am not loading this class for single sites. Please let me know what am I missing. |
Repository owner
deleted a comment
Oct 3, 2019
Repository owner
deleted a comment
Oct 4, 2019
sudar
suggested changes
Oct 18, 2019
Contributor
sudar
left a comment
sudar
left a comment
There was a problem hiding this comment.
Just left some minor comments. Once it is fixed, this can be merged.
include/Core/BulkDelete.php
Outdated
| * | ||
| * @since 6.1.0 | ||
| * | ||
| * @var \BulkWP\BulkDelete\Multisite\MultisiteAdminUIBuilder |
Contributor
There was a problem hiding this comment.
Suggested change
| * @var \BulkWP\BulkDelete\Multisite\MultisiteAdminUIBuilder | |
| * @var \BulkWP\BulkDelete\Core\Multisite\MultisiteAdminUIBuilder |
Repository owner
deleted a comment
Oct 18, 2019
Repository owner
deleted a comment
Nov 4, 2019
Contributor
|
Complexity increasing per file
==============================
- include/Core/Multisite/MultisiteAdminUIBuilder.php 3
- tests/wp-unit/include/Core/Users/Modules/DeleteUsersByUserMetaInMultisiteModuleTest.php 6
- include/Core/Users/UsersModule.php 2
- include/Core/Users/DeleteUsersInMultisitePage.php 1
- include/Core/Users/Modules/DeleteUsersByUserMetaInMultisiteModule.php 2
See the complete overview on Codacy |
Repository owner
deleted a comment
Nov 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #671
@sudar Please look into multisite test issue i.e.,tests are erroring when run without WP_MULTISITE=1.