Skip to content

fix: agent config not picked up from parameters#397

Open
lenkan wants to merge 2 commits intoWebOfTrust:mainfrom
lenkan:fix-config-dt
Open

fix: agent config not picked up from parameters#397
lenkan wants to merge 2 commits intoWebOfTrust:mainfrom
lenkan:fix-config-dt

Conversation

@lenkan
Copy link
Collaborator

@lenkan lenkan commented Nov 3, 2025

When agent URLs where only provided through parameters (from env variables), the "dt" field was not set, which caused keripy to ignore the configuration. This PR ensure that "dt" field is set.

When agent URLs where only provided through parameters (from env
variables), the "dt" field was not set, which caused keripy to ignore
the configuration. This PR ensure that "dt" field is set.
@lenkan lenkan requested review from iFergal and kentbull November 3, 2025 14:48
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.63%. Comparing base (1f22907) to head (e656d30).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
+ Coverage   86.60%   86.63%   +0.03%     
==========================================
  Files          25       25              
  Lines        5286     5299      +13     
==========================================
+ Hits         4578     4591      +13     
  Misses        708      708              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@kentbull kentbull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KRAM dictates timestamps should be checked in order to protect

There is a security concern with adding a datetime

@kentbull
Copy link
Collaborator

@lenkan please rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants