Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Santinni už jsem to všemožně testoval, pročítal kód a prošlo to asi 5 agentskými code reviews ale stejně na to pls alespoň letmo koukni, je to docela velká změna.
Tak obecně, jedná se o implementaci chunked uploadu na nahrávání velkých semínek, kde místo obrovského limitu na povolený upload size se nahrávají velké soubory (až do 500MB) po 4MB chuncích a až jakmile je celý soubor nahraný, tak se uloží do databáze.
Pokud se v TC custom_seeds nezmění, uloží se rychle, pokud se tam ale nahraje 100MB soubor, bude se to ukládat ~1min+ nebo to spadne na timeoutu, tam to prostě trvá kvůli zápisu do databáze.
Zároveň se nyní tyhle velké TC nezmrazují, protože by to v podstatě zdvojnásobilo množství dat v databázi. Dá se to nastavit, ale na rovinu by to chtělo krapet překopat tenhle upload na něco asynchroního, možná to bude potřeba i pro samotný upload pokud se budou opravdu uploadovat 100MB+ soubory.