fix: KeyError in get_sri_candidates when tag has no src/href#1462
Merged
Conversation
append_with_src only set 'src' and 'src-same-origin' keys when an href/src attribute was found. Tags without either attribute caused a KeyError on line 401 of get_sri_candidates. Move the key assignments outside the conditional so both keys are always present. When no src is found, defaults to None and False. Fixes #1461
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
append_with_src only set 'src' and 'src-same-origin' keys when an href/src attribute was found. Tags without either attribute caused a KeyError on line 401 of get_sri_candidates.
Move the key assignments outside the conditional so both keys are always present. When no src is found, defaults to None and False.
Fixes #1461