Skip to content

Retry or fail on dispatch failure#5

Open
jameskoll-whatnot wants to merge 2 commits into
masterfrom
jameskoll-whatnot/DT-709
Open

Retry or fail on dispatch failure#5
jameskoll-whatnot wants to merge 2 commits into
masterfrom
jameskoll-whatnot/DT-709

Conversation

@jameskoll-whatnot

@jameskoll-whatnot jameskoll-whatnot commented Jul 7, 2026

Copy link
Copy Markdown

Background

Errors when dispatching aren't handled well, leaving doomed workflows polling for results until the step times out. Example: https://github.com/Whatnot-Inc/whatnot_backend/actions/runs/28871267338/job/85636518486

Going for functional over perfection here, as this workflow will be a lot less important and maybe even unused in a post buildkite world

Changes

  • Detect errors from dispatch response and
    • If it's a clear failure, immediately fail
    • If it's an ambiguous failure, retry once before failing
  • Have claude rework the unit tests to switch from curl to gh mocking. This was changed in the previous PR contributed by blacksmith
  • Have claude update unit tests to test for the new expected behaviors

Testing

@jameskoll-whatnot jameskoll-whatnot changed the title maybe add workflow retries Retry or fail on dispatch failure Jul 7, 2026
@jameskoll-whatnot jameskoll-whatnot marked this pull request as ready for review July 7, 2026 21:02
@jameskoll-whatnot jameskoll-whatnot requested a review from a team as a code owner July 7, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants