Change default Joomla database name to joomla_db and add installation summary dialog#464
Change default Joomla database name to joomla_db and add installation summary dialog#464
Conversation
Co-authored-by: crramirez <8397379+crramirez@users.noreply.github.com>
|
@copilot change the default database name in the whole script from joomla to joomla_db |
Co-authored-by: crramirez <8397379+crramirez@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the Joomla installer in pengwin-setup to use a new default database name and to surface the post-installation summary in the dialog UI (in addition to console output), consistent with other installers.
Changes:
- Changed default Joomla database name from
joomlatojoomla_dbin the installer SQL and summary output. - Added a
message --msgboxdialog showing the installation summary (DB info + next step). - Updated Joomla install/uninstall tests to assert against the new database name.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
pengwin-setup.d/joomla.sh |
Uses joomla_db in SQL grants/output and adds a post-install summary msgbox. |
tests/joomla.sh |
Updates DB existence assertions to look for joomla_db. |
…, fix test assertions Co-authored-by: crramirez <8397379+crramirez@users.noreply.github.com>
|
|
||
| message --title "Joomla ${JOOMLA_VERSION}" --msgbox "Joomla ${JOOMLA_VERSION} installation complete!\n\nDatabase: ${JOOMLA_DB_NAME}\nDatabase User: joomla\nDatabase Password: joomla\n\nThe Joomla installer will open in your browser after you close this dialog." 12 70 | ||
|
|
||
| wslview "http://localhost/joomla_root/index.php" 2>/dev/null || echo "Please open http://localhost/joomla_root/index.php in your browser" |
There was a problem hiding this comment.
@copilot move the message below this line. the message must be on the screen at the same time the browser opens. also revert the message to "Opening Joomla installer in browser..."
There was a problem hiding this comment.
Done in 8cd7c0b. Moved the message dialog to after the wslview call so the browser opens first and the dialog appears simultaneously. Reverted the text back to "Opening Joomla installer in browser...".
…installer in browser...' Co-authored-by: crramirez <8397379+crramirez@users.noreply.github.com>
joomlatojoomla_dbin installer and testsJOOMLA_DB_NAME) to avoid future inconsistencieswslviewcall so browser opens simultaneously with the dialog|| echo 0pattern in tests that can produce "0 0" — use|| trueinsteadmysql -N -Bto avoid matching column headersOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.