Skip to content

Change default Joomla database name to joomla_db and add installation summary dialog#464

Open
Copilot wants to merge 5 commits intomasterfrom
copilot/add-installation-complete-dialog
Open

Change default Joomla database name to joomla_db and add installation summary dialog#464
Copilot wants to merge 5 commits intomasterfrom
copilot/add-installation-complete-dialog

Conversation

Copy link
Contributor

Copilot AI commented Feb 7, 2026

  • Change default database name from joomla to joomla_db in installer and tests
  • Extract database name into a constant variable (JOOMLA_DB_NAME) to avoid future inconsistencies
  • Move message dialog after wslview call so browser opens simultaneously with the dialog
  • Revert dialog text back to "Opening Joomla installer in browser..."
  • Fix || echo 0 pattern in tests that can produce "0 0" — use || true instead
  • Fix tests to use mysql -N -B to avoid matching column headers
  • Run shellcheck to validate all changes
Original prompt

at the end, the joomla installer shows the following message in console:

echo ""
echo "Joomla ${JOOMLA_VERSION} installation complete!"
echo "Database: joomla"
echo "Database User: joomla"
echo "Database Password: joomla"
echo ""
echo "Opening Joomla installer in browser..."

make this message also available using the message command as a message dialog


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: crramirez <8397379+crramirez@users.noreply.github.com>
Copilot AI changed the title [WIP] Add message dialog for Joomla installation complete notification Add message dialog for Joomla installation summary Feb 7, 2026
Copilot AI requested a review from crramirez February 7, 2026 15:12
@crramirez
Copy link
Collaborator

@copilot change the default database name in the whole script from joomla to joomla_db

Co-authored-by: crramirez <8397379+crramirez@users.noreply.github.com>
Copilot AI changed the title Add message dialog for Joomla installation summary Change default Joomla database name to joomla_db and add installation summary dialog Feb 9, 2026
@crramirez crramirez marked this pull request as ready for review February 9, 2026 18:17
Copilot AI review requested due to automatic review settings February 9, 2026 18:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Joomla installer in pengwin-setup to use a new default database name and to surface the post-installation summary in the dialog UI (in addition to console output), consistent with other installers.

Changes:

  • Changed default Joomla database name from joomla to joomla_db in the installer SQL and summary output.
  • Added a message --msgbox dialog showing the installation summary (DB info + next step).
  • Updated Joomla install/uninstall tests to assert against the new database name.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
pengwin-setup.d/joomla.sh Uses joomla_db in SQL grants/output and adds a post-install summary msgbox.
tests/joomla.sh Updates DB existence assertions to look for joomla_db.

…, fix test assertions

Co-authored-by: crramirez <8397379+crramirez@users.noreply.github.com>

message --title "Joomla ${JOOMLA_VERSION}" --msgbox "Joomla ${JOOMLA_VERSION} installation complete!\n\nDatabase: ${JOOMLA_DB_NAME}\nDatabase User: joomla\nDatabase Password: joomla\n\nThe Joomla installer will open in your browser after you close this dialog." 12 70

wslview "http://localhost/joomla_root/index.php" 2>/dev/null || echo "Please open http://localhost/joomla_root/index.php in your browser"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot move the message below this line. the message must be on the screen at the same time the browser opens. also revert the message to "Opening Joomla installer in browser..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 8cd7c0b. Moved the message dialog to after the wslview call so the browser opens first and the dialog appears simultaneously. Reverted the text back to "Opening Joomla installer in browser...".

…installer in browser...'

Co-authored-by: crramirez <8397379+crramirez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants