[FIX] Fix escalation block on quick chat establish#52
Open
AlexanderKanakis wants to merge 1 commit intomasterfrom
Open
[FIX] Fix escalation block on quick chat establish#52AlexanderKanakis wants to merge 1 commit intomasterfrom
AlexanderKanakis wants to merge 1 commit intomasterfrom
Conversation
|
@Shailesh351 have a look please. |
Shailesh351
reviewed
Feb 28, 2022
Comment on lines
+89
to
+94
| let salesforceAgentName; | ||
| for (const msg of messageArray) { | ||
| if (msg.message.name) { | ||
| salesforceAgentName = msg.message.name; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
We are also accessing chasitorIdleTimeout and sneakPeekEnabled from the chatEstablishedMessage. Shouldn't we also add those?
Comment on lines
+46
to
+48
| if ((Object.keys(res).length === 0 || res !== 'undefined') && response.content === '{}') { | ||
| response = res; | ||
| } |
Collaborator
There was a problem hiding this comment.
Why response = res; when Object.keys(res).length === 0?
Shailesh351
reviewed
Feb 28, 2022
Collaborator
Shailesh351
left a comment
Shailesh351
left a comment
There was a problem hiding this comment.
When I tried this locally, SF Agent Name is not showing up in Livechat Widget
|
@AlexanderKanakis are there any RC logging associated with this crash you are describing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix makes sure that we retain the response from Salesforce when the Salesforce agent accepts a visitor in the short time between connecting to Salesforce and looking for an agent