Skip to content

Comments

Cws 1256 reset app timer#79

Open
csmith14 wants to merge 22 commits intomasterfrom
CWS-1256-reset-app-timer
Open

Cws 1256 reset app timer#79
csmith14 wants to merge 22 commits intomasterfrom
CWS-1256-reset-app-timer

Conversation

@csmith14
Copy link
Collaborator

Sends a message with timeout fields, using specific message text, which is filtered and ignored by LiveChat. This enables reset of both app and widget timers when user types.

This also addresses the bug described in WideChat/Rocket.Chat#1305 by checking for widget control before handling a timeout message from the LiveChat widget.

@ear-dev
Copy link

ear-dev commented Sep 27, 2022

@bhardwajaditya can you review please?

@ear-dev
Copy link

ear-dev commented Sep 28, 2022

@csmith14 can you fix the conflicts please? thanks.

@ear-dev
Copy link

ear-dev commented Sep 28, 2022

@csmith14 I've tested this and it looks pretty good. A couple of issues I'm seeing:

  • If the visitor starts typing in the composer, but does not send, then the chat will never timeout. Is there a way to protect against that?
  • I've got the sound enabled on my widget, so the chime rings every time a message comes through. That's default RC behavior I think. However, I'm getting a lot of extra chimes when there is no visible message. I suspect that is the control messsages you are sending? Is there a way to disable the chime for those messages?

@Shailesh351
Copy link
Collaborator

@csmith14 @ear-dev We should try to avoid using messages as the control mechanism for these typing events if possible. Because considering the frequency of these typing messages(~ every 3sec) it will just increase the DB size unnecessarily. And there will be unexpected issues like the one @ear-dev mentioned, notification sound.

Also, it will affect analytics(no of messages).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants