Open
Conversation
added 20 commits
September 1, 2022 14:25
This was referenced Sep 26, 2022
|
@bhardwajaditya can you review please? |
|
@csmith14 can you fix the conflicts please? thanks. |
|
@csmith14 I've tested this and it looks pretty good. A couple of issues I'm seeing:
|
Collaborator
|
@csmith14 @ear-dev We should try to avoid using messages as the control mechanism for these typing events if possible. Because considering the frequency of these typing messages(~ every 3sec) it will just increase the DB size unnecessarily. And there will be unexpected issues like the one @ear-dev mentioned, notification sound. Also, it will affect analytics(no of messages). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sends a message with timeout fields, using specific message text, which is filtered and ignored by LiveChat. This enables reset of both app and widget timers when user types.
This also addresses the bug described in WideChat/Rocket.Chat#1305 by checking for widget control before handling a timeout message from the LiveChat widget.