Skip to content

Propagate changes from main into development #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wikid82 merged 4 commits into from
Apr 4, 2026
Merged

Propagate changes from main into development #907

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e32f3df
chore(docker): update GeoLite2-Country.mmdb checksum
Wikid82 Mar 30, 2026
a78529e
Merge pull request #889 from Wikid82/nightly
Wikid82 Mar 30, 2026
ecf314b
Merge branch 'main' into bot/update-geolite2-checksum
Wikid82 Mar 30, 2026
1911003
Merge pull request #888 from Wikid82/bot/update-geolite2-checksum
Wikid82 Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ SHELL ["/bin/ash", "-o", "pipefail", "-c"]
# Note: In production, users should provide their own MaxMind license key
# This uses the publicly available GeoLite2 database
# In CI, timeout quickly rather than retrying to save build time
ARG GEOLITE2_COUNTRY_SHA256=c6549807950f93f609d6433fa295fa517fbdec0ad975a4aafba69c136d5d2347
ARG GEOLITE2_COUNTRY_SHA256=7840f4b8891e7c866f948d4b020cdc12aeea51b09450b44ad96d1f14f6e32879
RUN mkdir -p /app/data/geoip && \
if [ "$CI" = "true" ] || [ "$CI" = "1" ]; then \
Comment on lines 459 to 463
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GEOLITE2_COUNTRY_SHA256 is defined/updated here but never used anywhere in the Dockerfile (only this ARG exists). As a result, the GeoLite2 download has no integrity check, and updating this value has no effect. Either wire this into the download step (verify the downloaded file hash) or remove the ARG to avoid a false sense of verification.

Copilot uses AI. Check for mistakes.
echo "⏱️ CI detected - quick download (10s timeout, no retries)"; \
Expand Down
Loading