Add custom 4xx/5xx error page templates

[DHardy-WMF]

Description

Added new templates for custom error pages in Django, along with 500.html in static for the NGINX config.

Rationale

Currently, Wikilink only has generic 500 error pages. These can be confusing for end users. We should create more informative error pages.

Phabricator Ticket

https://phabricator.wikimedia.org/T350820

How Has This Been Tested?

Setting DEBUG = False in extlinks/settings/local.py.

Screenshots of your changes (if appropriate):

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

[DHardy-WMF]

Also, not sure if you saw my comment in the other review, but we should try to keep the PR template for documentation purposes.

Yes I saw it, but I can't find the PR template markdown.

[DHardy-WMF]

Also, not sure if you saw my comment in the other review, but we should try to keep the PR template for documentation purposes.

Yes I saw it, but I can't find the PR template markdown.

You should be able to go to old/closed pull requests and copy the template from there. Though, this isn't necessarily a blocker to merging it in.

Done!

[suecarmol]

Thanks for creating the templates. Some changes need to be made before we can merge this.

[jsnshrmn]

Noting that I'm not able to get the custom 500 page when I raise arbitrary exceptions within django; I've spent some time debugging, but have to call it a day.

[jsnshrmn]

I'd expect to see a custom 500 handler in there somewhere?

[DHardy-WMF]

Noting that I'm not able to get the custom 500 page when I raise arbitrary exceptions within django; I've spent some time debugging, but have to call it a day.

That's strange... I can't seem to reproduce the issue. Did you explicitly run docker compose up -d and docker compose restart nginx to ensure the configs have updated properly?

[jsnshrmn]

yep, the 500 page is working fine from nginx if I take down the django service, but if I try to get it served from django I get the generic page. Verified by connecting directly to the django http server

[suecarmol]

yep, the 500 page is working fine from nginx if I take down the django service, but if I try to get it served from django I get the generic page. Verified by connecting directly to the django http server

Did you build your local environment with the Django Debug Toolbar? Right now, the 500 pages are only added to Django when DDT is on.

[DHardy-WMF]

yep, the 500 page is working fine from nginx if I take down the django service, but if I try to get it served from django I get the generic page. Verified by connecting directly to the django http server

Okay I was able to reproduce by connecting directly to Django. This should be fixed now!

[jsnshrmn]

👍