Add retry logic for all management commands#470
Merged
Conversation
4b5d5d1 to
1d1feec
Compare
katydidnot
reviewed
Sep 12, 2025
extlinks/aggregates/management/helpers/aggregate_archive_command.py
Outdated
Show resolved
Hide resolved
c7ccc1f to
1e6ba12
Compare
Bug: T403209 Change-Id: Idd17a703d4bf64a0aa46eef875938dad6ef681e7
1e6ba12 to
d2db009
Compare
katydidnot
approved these changes
Sep 15, 2025
suecarmol
approved these changes
Sep 16, 2025
Contributor
suecarmol
left a comment
There was a problem hiding this comment.
Thank you for implementing the retry for this command. This might be useful for other commands in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rationale
We were having quiet cron failure with no retries for linksearchtotal_collect which should run weekly. this change allows for some retries and makes the logs noisier for easier diagnostics.
Phabricator Ticket
https://phabricator.wikimedia.org/T403209
How Has This Been Tested?
Tested by running locally
Screenshots of your changes (if appropriate):
Types of changes
What types of changes does your code introduce? Add an
xin all the boxes that apply: