Address review feedback on context increment/decrement helpers#170
Merged
Conversation
- Use cond directly rather than nesting it inside an if - Use the symbols 'before and 'after instead of strings, matching the existing deadgrep--context button handler - Fix the deadgrep-decrement-after-context docstring, which previously said "Increment" Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146BcDvXCLTfdcXE3KFoWL3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #161, applying the review feedback left on that PR:
conddirectly rather than nesting it inside anif. Thedeadgrep-restartcall now lives inside each matching branch, which preserves the original behaviour (only restart when the context actually changes) without relying on thesetqreturn value as theifcondition.'before/'afterinstead of strings, matching the existingdeadgrep--contextbutton handler that already dispatches on thebefore/aftersymbols viacl-case. The docstring is updated to match.deadgrep-decrement-after-contextdocstring, which previously read "Increment context after."No behavioural change beyond the docstring fix — purely a style/consistency cleanup.
🤖 Generated with Claude Code
https://claude.ai/code/session_0146BcDvXCLTfdcXE3KFoWL3
Generated by Claude Code