Add --hidden and --glob=!/.git flags to ripgrep arguments#171
Merged
Conversation
The test still expected the old argument list, but the code now adds --hidden (when deadgrep--skip-if-hidden is nil, the default) and --glob=!/.git (when deadgrep--skip-if-vcs-ignore is t, the default). These flags were introduced when hidden-file and .gitignore searching was added, but this test was never updated, so it failed on every CI run across all Emacs versions. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012UXzTRanhaXH8PAM8KyVPX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the deadgrep ripgrep argument generation to include
--hiddenand--glob=!/.gitflags in all search configurations. This ensures hidden files are searched while explicitly excluding the.gitdirectory.Changes
--hiddenflag to enable searching in hidden files and directories--glob=!/.gitflag to exclude the.gitdirectory from search resultsdeadgrep--argumentstest to reflect the new expected argument lists:Details
These flags are now consistently applied across all search invocations, regardless of the search type, case sensitivity mode, or file filters used. The
--hiddenflag allows deadgrep to search in hidden files (those starting with.), while the--glob=!/.gitpattern prevents the.gitdirectory from being included in results, which is typically desired behavior for most searches.https://claude.ai/code/session_012UXzTRanhaXH8PAM8KyVPX