Public profile pages and basic contribution management#96
Open
nitinseshadri wants to merge 9 commits intoWinWorldPC:masterfrom
Open
Public profile pages and basic contribution management#96nitinseshadri wants to merge 9 commits intoWinWorldPC:masterfrom
nitinseshadri wants to merge 9 commits intoWinWorldPC:masterfrom
Conversation
Contributor
|
Code wise this looks good so far, and I'll give it a try locally, but some thoughts:
|
Contributor
Author
Yeah, the idea is that these will become the profile pages for the forum at some point. Vanilla allows you to set custom profile URLs, but it would require some changes to the SSO code as detailed here: https://open.vanillaforums.com/discussion/28209/change-the-url-of-user-profile |
Contributor
Author
|
@NattyNarwhal Any updates on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
/user/profile/<username>or/user/profile/<uuid>, or, to view their own profile, users can go to/user/profileor click the link in the user menu./library/my/contributions(same route as before) or clicking the link in the user menu.allowContributions(boolean)./library/contributeis now operable, but largely incomplete. For now, I recommend setting the setting mentioned above tofalse, and advising admins to not click "Create Release" in the admin interface contribution page.