Merged
Conversation
- Merge legacy and modern modules - Use snake_case for Gradle module name to follow the naming convention - Update to JAVA 21 - Move adventure to spigot's runtime dependency loader (No need to relocation/include) - Fixed grammar errors - Code base cleanup This refactor also fixed other related chained problems - Unable to send messages on Spigot platforms - Fixed wrong item display name in Spigot & <= 1.20.5 Paper - Fixed wrong item display name (has white bracket, it's inconsistent with the view in player inventory)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged legacy and modern modules for better maintenance. The separated legacy and modern modules are for dealing with the different APIs changed between Spigot and Paper. However, it becomes a huge problem synchronizing changes between two modules if some major changes happen.
Instead, for now, only methods using the API that have changed between Spigot/Paper versions are isolated from the main module, as "NMS" modules. Treats 1.12.2 as the base version, only APIs changed in further versions will be moved to the new module, based on the last "NMS" version module, and override. This practice can prevent copy pasting the exact same methods in every "NMS" version module, and still, easier for maintenance.
Changes
This refactor also fixed other related chained problems
biomeand%distance%placeholders are not workingKnown issue: