feat(natscluster): block deletion while accounts are bound#290
Merged
Conversation
669ccba to
44c637f
Compare
Signed-off-by: Henri Ropponen <henriropponen@gmail.com>
…econciler Signed-off-by: Henri Ropponen <henriropponen@gmail.com>
Signed-off-by: Henri Ropponen <henriropponen@gmail.com>
Signed-off-by: Henri Ropponen <henriropponen@gmail.com>
Signed-off-by: Henri Ropponen <henriropponen@gmail.com>
…accounts exist Signed-off-by: Henri Ropponen <henriropponen@gmail.com>
Signed-off-by: Henri Ropponen <henriropponen@gmail.com>
Signed-off-by: Henri Ropponen <henriropponen@gmail.com>
Signed-off-by: Henri Ropponen <henriropponen@gmail.com>
0e7da0a to
6f517b7
Compare
6f517b7 to
5beb0fa
Compare
choufraise
previously approved these changes
May 12, 2026
choufraise
approved these changes
May 12, 2026
Signed-off-by: Henri Ropponen <henriropponen@gmail.com>
Signed-off-by: Henri Ropponen <henriropponen@gmail.com>
8f9fb29 to
c0a603f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent
NatsClusterdeletion from completing whileAccountresources are still bound to that cluster. This protects cluster/account relationships from being orphaned and surfaces the blocked deletion state through controller status until the bindings are removed.What changed
NatsClusterfinalizer and deletion logic that checks for bound accounts by cluster UID before allowing removalAccountdelete events from theNatsClustercontroller so deletion is retried after bindings are removedAccountresources viaaccount.nauth.io/nats-cluster-idnatsclustersupdates/finalizer updates and add Helm test coverage for those permissionsNatsClusterdeletion is blocked until the bound account is deletedHow to validate
make lint make test make test-e2e