refactor(test): centralize shared test helpers#298
Merged
Conversation
Add internal/testutil helpers for sanitizing, hashing, and scoping test resource names. Replace duplicated helper implementations across controller and k8s adapter tests. Signed-off-by: Thobias Karlsson <thobias.karlsson@gmail.com>
henriropp
previously approved these changes
May 13, 2026
Contributor
henriropp
left a comment
henriropp
left a comment
There was a problem hiding this comment.
Nice! saw one Fixme comment, fix now or later?
Add shared testutil helpers for creating NATS operator, account, and user keys. Reuse them across controller, k8s adapter, nats, and core tests. Signed-off-by: Thobias Karlsson <thobias.karlsson@gmail.com>
Add shared fixed NATS operator and account test keys in testutil and reuse them from core account tests. Replace the core-local test key helper with generic seed/value helpers in internal/testutil. Signed-off-by: Thobias Karlsson <thobias.karlsson@gmail.com>
Add testutil helpers for locating project CRDs and envtest binaries from the discovered repository root. Replace hardcoded ../../../../ paths in envtest suites with shared project resource helpers. Signed-off-by: Thobias Karlsson <thobias.karlsson@gmail.com>
henriropp
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Controller and k8s adapter tests duplicated helper logic for scoped test names, short hashes, and envtest binary discovery.
This adds
internal/testutilhelpers for those shared concerns and rewires the existing tests to use them, keeping test setup consistent across packages.Commits