Feature/ace3 milestone 8 move quest frames to UI folder#121
Conversation
Wishmaster117
deleted the
feature/ace3-Milestone-8-Move-quest-frames-to-UI-folder
branch
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8835f28fcd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return true | ||
| end | ||
|
|
||
| local tNonSpellStreak = tonumber(pCollectionState.nonSpellStreak) or 0 | ||
| local tNonSpellThreshold = tonumber(SPELLBOOK_END_NON_SPELL_STREAK) or 4 | ||
| if(pCollectionState.hasCollectedSpell and tNonSpellStreak >= tNonSpellThreshold) then | ||
| return true | ||
| return false |
There was a problem hiding this comment.
shouldFinishSpellbookCollection() now returns true only for isSpellbookFooterLine(), and the old nonSpellStreak fallback/counter were removed from handleSpellbookChatLine(). On any realm/locale where the trailing stats whisper does not match the footer patterns in UI/MultiBotSpell.lua (or never arrives because that whisper is throttled), pButton.waitFor stays stuck at "SPELL" and finishSpellbookCollection() is never called, so the spellbook never opens. The previous 4-line non-spell fallback covered those unsupported formats.
Useful? React with 👍 / 👎.
| if MultiBot.InitializeGameObjectResultsFrame then MultiBot.InitializeGameObjectResultsFrame() end | ||
| if MultiBot.InitializeGameObjectCopyFrame then MultiBot.InitializeGameObjectCopyFrame() end |
There was a problem hiding this comment.
These calls eagerly create both GameObject AceGUI windows during Core/MultiBotInit.lua load. In AceAddon mode Config_Ensure() does not run until OnInitialize (Core/MultiBot.lua:1015-1019), so MultiBot.BindAceWindowPosition() returns early with MultiBot.db == nil and never restores or saves positions for these windows. The previous inline implementation built the GameObject popup/copy box lazily on first use, so this change regresses persisted placement for the rest of the session.
Useful? React with 👍 / 👎.
1 participant
No description provided.