Added LunaLuaSetWindowScale and LunaLuaGetWindowSize#57
Open
MrDoubleA232 wants to merge 1 commit intoWohlSoft:masterfrom
Open
Added LunaLuaSetWindowScale and LunaLuaGetWindowSize#57MrDoubleA232 wants to merge 1 commit intoWohlSoft:masterfrom
MrDoubleA232 wants to merge 1 commit intoWohlSoft:masterfrom
Conversation
Contributor
|
I've been thinking about this topic a bit. Some things I had in mind, that you accounted for and I'm glad to see:
Some things I think it's missing:
In addition. I was thinking about the idea of implementing a
This method tries to combine respecting whatever the player has done with window size already, with rounding to a clean-looking window size of the appropriate aspect ratio. |
Contributor
Author
|
This is really helpful feedback! I'll try to implement the points that you mentioned into this once I get the chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two FFI functions:
If there are any issues with this implementation or a better way to go about things, let me know!