649 - Update Github Action with correct secret name for Slack bot#652
Open
silkenodwell wants to merge 1 commit intoWomen-Coding-Community:mainfrom
Open
649 - Update Github Action with correct secret name for Slack bot#652silkenodwell wants to merge 1 commit intoWomen-Coding-Community:mainfrom
silkenodwell wants to merge 1 commit intoWomen-Coding-Community:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #649.
Fix the name of the secrets:
It should be SLACK_BOT_WEBHOOK instead of SLACK_WEBHOOK_URL
Also, there was a try-except block that checked for a key error when using os.getenv. But os.getenv doesn't throw a KeyError, it just returns None if the key does not exist. This PR fixes this error handling to correctly throw an error if SLACK_BOT_WEBHOOK is not an environment variable.
Change Type
Related Issue
#649
Pull request checklist
Please check if your PR fulfills the following requirements: