Skip to content

Update leadership team #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ann-kilzer merged 4 commits into from
Feb 28, 2026
Merged

Update leadership team #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f22a40
Update leadership team and tests
ann-kilzer Feb 28, 2026
7bd1c12
Remove Ann from codeowners
ann-kilzer Feb 28, 2026
094626b
Update src/routes/Team/team.json
ann-kilzer Feb 28, 2026
53d5561
Use JA interpunct to follow copilot review feedback
ann-kilzer Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
# the repo. Unless a later match takes precedence,
# @global-owner1 and @global-owner2 will be requested for
# review when someone opens a pull request.
* @ann-kilzer @RossellaFer
* @RossellaFer

35 changes: 18 additions & 17 deletions e2e/team.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,21 +27,22 @@ test('shows the team in English', async ({ page }) => {
const cards = await teamContainer.getByLabel('team-member-card').all()
expect(cards).toHaveLength(9)

await verifyTeamMemberCard(cards[0], 'Ann Kilzer', 'Director')
await verifyTeamMemberCard(cards[1], 'Paty Cortez', 'Director')
await verifyTeamMemberCard(cards[2], 'Maria Tenorio', 'Lead')
await verifyTeamMemberCard(cards[3], 'Daria Vazhenina', 'ML & Data Science Lead')
await verifyTeamMemberCard(cards[4], 'Ania Nakayama', 'Lead')
await verifyTeamMemberCard(cards[5], 'Rossella Ferrandino', 'Lead')
await verifyTeamMemberCard(cards[6], 'Ishika Bhosale', 'Lead')

await verifyTeamMemberCard(cards[0], 'Paty Cortez', 'Director')
await verifyTeamMemberCard(cards[1], 'Maria Tenorio', 'Lead')
await verifyTeamMemberCard(cards[2], 'Daria Vazhenina', 'ML & Data Science Lead')
await verifyTeamMemberCard(cards[3], 'Rossella Ferrandino', 'Lead')
await verifyTeamMemberCard(cards[4], 'Ishika Bhosale', 'Lead')
await verifyTeamMemberCard(cards[5], 'Ann Kilzer', 'Co-founder & Legacy Director')
await verifyTeamMemberCard(cards[6], 'Ania Nakayama', 'Legacy Lead')
await verifyTeamMemberCard(cards[7], 'Krizza Bullecer', 'Legacy Lead')
await verifyTeamMemberCard(cards[8], 'Aidan Fournier', 'Legacy Lead')

// verify link
const links = await page.getByLabel('link-wrapper').all()
expect(links).toHaveLength(2)
const annLink = links[0]
const rossLink = links[1]
const rossLink = links[0]
const annLink = links[1]
await expect(annLink).toBeVisible()
Comment on lines 41 to 46
Copy link

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link assertions rely on links[0]/links[1] DOM order after getByLabel('link-wrapper').all(). This is a bit brittle: adding another URL’d team member or reordering team.json will break the test even if behavior is correct. Consider scoping the link lookup to the specific member card (find the card by member name, then assert the wrapped link’s href/target).

Copilot uses AI. Check for mistakes.
Copy link
Collaborator Author

@ann-kilzer ann-kilzer Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

Copy link
Collaborator Author

@ann-kilzer ann-kilzer Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's valid... this is brittle

await expect(annLink).toHaveRole('link')
await expect(annLink).toHaveAttribute('href', 'https://annkilzer.net')
Expand Down Expand Up @@ -77,13 +78,13 @@ test('shows the team in Japanese', async ({ page, viewport }) => {
const cards = await teamContainer.getByLabel('team-member-card').all()
expect(cards).toHaveLength(9)

await verifyTeamMemberCard(cards[0], 'キルザー·杏', 'ディレクター')
await verifyTeamMemberCard(cards[1], 'Paty Cortez', 'ディレクター')
await verifyTeamMemberCard(cards[2], 'Maria Tenorio', 'リード')
await verifyTeamMemberCard(cards[3], 'バジェニナ・ダリヤ', 'ML＆データサイエンス・リード')
await verifyTeamMemberCard(cards[4], 'Ania Nakayama', 'リード')
await verifyTeamMemberCard(cards[5], 'フェッランディノ・ロッセッラ', 'リード')
await verifyTeamMemberCard(cards[6], 'ビーオゼール・イシカ', 'リード')
await verifyTeamMemberCard(cards[7], 'ブレサー　クリザ', 'レガシー・リード')
await verifyTeamMemberCard(cards[0], 'Paty Cortez', 'ディレクター')
await verifyTeamMemberCard(cards[1], 'Maria Tenorio', 'リード')
await verifyTeamMemberCard(cards[2], 'バジェニナ・ダリヤ', 'ML＆データサイエンス・リード')
await verifyTeamMemberCard(cards[3], 'フェッランディノ・ロッセッラ', 'リード')
await verifyTeamMemberCard(cards[4], 'ビーオゼール・イシカ', 'リード')
await verifyTeamMemberCard(cards[5], 'キルザー・杏', '共同創立者・レガシー・ディレクター')
await verifyTeamMemberCard(cards[6], '中山アンナ', 'レガシー・リード')
await verifyTeamMemberCard(cards[7], 'ブレサー・クリザ', 'レガシー・リード')
await verifyTeamMemberCard(cards[8], 'エイデン・フォニエ', 'レガシー・リード')
})
34 changes: 17 additions & 17 deletions src/routes/Team/team.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,4 @@
[
{
"nameEN": "Ann Kilzer",
"nameJA": "キルザー·杏",
"titleEN": "Director",
"titleJA": "ディレクター",
"image": "Ann.jpg",
"url": "https://annkilzer.net"
},
{
"nameEN": "Paty Cortez",
"nameJA": "",
Expand All @@ -31,14 +23,6 @@
"image": "Daria.jpg",
"url": ""
},
{
"nameEN": "Ania Nakayama",
"nameJA": "",
"titleEN": "Lead",
"titleJA": "リード",
"image": "Ania.jpg",
"url": ""
},
{
"nameEN": "Rossella Ferrandino",
"nameJA": "フェッランディノ・ロッセッラ",
Expand All @@ -55,9 +39,25 @@
"image": "Ishika.jpg",
"url": ""
},
{
"nameEN": "Ann Kilzer",
"nameJA": "キルザー・杏",
"titleEN": "Co-founder & Legacy Director",
"titleJA": "共同創立者・レガシー・ディレクター",
"image": "Ann.jpg",
"url": "https://annkilzer.net"
},
{
"nameEN": "Ania Nakayama",
"nameJA": "中山アンナ",
Copy link
Collaborator Author

@ann-kilzer ann-kilzer Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is from her LinkedIn page

"titleEN": "Legacy Lead",
"titleJA": "レガシー・リード",
"image": "Ania.jpg",
"url": ""
},
{
"nameEN": "Krizza Bullecer",
"nameJA": "ブレサー　クリザ",
"nameJA": "ブレサー・クリザ",
Copy link
Collaborator Author

@ann-kilzer ann-kilzer Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whitespace was an invisible unicode character so let's use an interpunct

"titleEN": "Legacy Lead",
"titleJA": "レガシー・リード",
"image": "Krizza.jpg",
Expand Down
Loading