Skip to content

Make e2e link assertions robust to team ordering changes #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: update-leadership-team
Choose a base branch
from
Open

Make e2e link assertions robust to team ordering changes #296

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
521455d
Initial plan
Copilot Feb 28, 2026
bf6ba78
Make link assertions more robust by scoping to member names
Copilot Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions e2e/team.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,19 @@ test('shows the team in English', async ({ page }) => {
await verifyTeamMemberCard(cards[7], 'Krizza Bullecer', 'Legacy Lead')
await verifyTeamMemberCard(cards[8], 'Aidan Fournier', 'Legacy Lead')

// verify link
const links = await page.getByLabel('link-wrapper').all()
expect(links).toHaveLength(2)
const rossLink = links[0]
const annLink = links[1]
await expect(annLink).toBeVisible()
await expect(annLink).toHaveRole('link')
await expect(annLink).toHaveAttribute('href', 'https://annkilzer.net')
await expect(annLink).toHaveAttribute('target', '_blank')
// verify links scoped to specific member cards
// Find link by locating the card with the member name, then getting the parent link wrapper
const rossLink = teamContainer.getByLabel('link-wrapper').filter({ has: page.getByText('Rossella Ferrandino') })
await expect(rossLink).toBeVisible()
await expect(rossLink).toHaveRole('link')
await expect(rossLink).toHaveAttribute('href', 'https://www.rossellaferrandino.info/')
await expect(rossLink).toHaveAttribute('target', '_blank')

const annLink = teamContainer.getByLabel('link-wrapper').filter({ has: page.getByText('Ann Kilzer') })
await expect(annLink).toBeVisible()
await expect(annLink).toHaveRole('link')
await expect(annLink).toHaveAttribute('href', 'https://annkilzer.net')
await expect(annLink).toHaveAttribute('target', '_blank')
})

test('shows the team in Japanese', async ({ page, viewport }) => {
Expand Down