Minor fixes#4
Open
andreasbotsikas wants to merge 3 commits into
Open
Conversation
Check if property exists ignoring case as it would produce a corrupted docx otherwise.
This will allow devs to save the document directly on a System.Web.HttpResponseStream without the need to create yet another memory stream.
This will avoid crashing the AddProperty. Another way would be to throw an application exception, but it's much more intuitive to set an empty string instead.
Contributor
|
Andreas, thanks - can you also please add corresponding unit tests for this contribution as well as your other pull request? |
Author
|
I will do so when I get some time. Do you have any naming conventions I should use? As for the stream, since I can't emulate a web request, I will try to use GZipStream which doesn't support seek either. |
Contributor
|
The original source code was using camel case convention so we are doing the same. We also haven't made any big (resharper-based) refactoring changes to the source code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check if property exists ignoring case as it would produce a corrupted docx otherwise.
Check if stream can seek before setting position. This will allow devs to save the document directly on a System.Web.HttpResponseStream without the need to create yet another memory stream.