Skip to content

Add do_blocks to the $autoEscapedFunctions list#2525

Open
dossy wants to merge 1 commit into
WordPress:developfrom
dossy:add-do_blocks-to-autoEscapedFunctions-list
Open

Add do_blocks to the $autoEscapedFunctions list#2525
dossy wants to merge 1 commit into
WordPress:developfrom
dossy:add-do_blocks-to-autoEscapedFunctions-list

Conversation

@dossy

@dossy dossy commented Mar 24, 2025

Copy link
Copy Markdown

Add do_blocks to the $autoEscapedFunctions list.

Closes #2524.

@jrfnl jrfnl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The do_blocks() function doesn't produce output, but returns instead, so it doesn't belong in the $autoEscapedFunctions list.

I also don't see the function escaping the output, so as far as I can see, it should also not be considered an escaping function. It's a re-rendering function, not an escaping function.

@dossy

dossy commented Apr 5, 2025

Copy link
Copy Markdown
Author

The do_blocks() function doesn't produce output, but returns instead, so it doesn't belong in the $autoEscapedFunctions list.

I also don't see the function escaping the output, so as far as I can see, it should also not be considered an escaping function. It's a re-rendering function, not an escaping function.

The exact same things can be said about do_shortcode(), and yet it is in the $autoEscapedFunctions list.

do_blocks() should be added for the exact same reasons do_shortcode() was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add do_blocks to the $autoEscapedFunctions list

2 participants