DB/PreparedSQLPlaceholders: add namespaced tests#2714
Draft
rodrigoprimo wants to merge 1 commit into
Draft
Conversation
Tests for namespaced calls to the wpdb class currently result in false positives: the sniff treats namespaced wpdb class calls as calls to the global wpdb class. Tests for namespaced calls to a function called sprintf() currently result in false negatives: the sniff treats these calls as calls to the global sprintf() function, causing them to not be flagged when they should be. Both issues are documented in the test case file and GitHub and will be fixed in the future.
rodrigoprimo
force-pushed
the
db-prepared-sql-placeholders-tests
branch
from
ecbf7c2 to
a21e071
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In preparation for PHPCS 4.0, which changes the tokenization of namespaced names, this PR adds tests with all forms of namespaced calls (partially qualified, fully qualified, and namespace-relative using the
namespacekeyword) as well as fully qualified global calls to theWordPress.DB.PreparedSQLPlaceholderssniff.Note: the new tests also document two known issues:
wpdbclass calls currently result in false positives:DB/PreparedSQLandDB/PreparedSQLPlaceholders: false positive for static method calls to non-global classes namedwpdb#2710.sprintf()currently result in false negatives (the sniff treats them as calls to the globalsprintf()function): DB/PreparedSQLPlaceholders: false negatives for namespaced and method calls to sprintf() #2720.Both issues will be addressed in a future PR.
Suggested changelog entry
N/A