WPHookHelper::get_hook_name_param(): add basic tests#2727
Conversation
jrfnl
left a comment
There was a problem hiding this comment.
@rodrigoprimo Thanks for creating this PR. I've left some small suggestions inline, but, and more importantly, a principle question about how the tests for this method are set up.
|
Thanks for the review, Juliette!
I reworked the tests in a new commit to address your feedback:
I also addressed the other comments you left. The unrealistic "hook name param missing" case was replaced with a named-parameter call that omits the hook name parameter, and the docblock types were updated to reflect the new structure after refactoring the tests. |
Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
Description
In preparation for supporting PHPCS 4.0, this PR adds unit tests for the
WPHookHelper::get_hook_name_param()method.Suggested changelog entry
N/A
Related issues/external references
Related to: #2272