Skip to content

i18n: Localize label attribute of additional blocks #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bph wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

i18n: Localize label attribute of additional blocks #826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions includes/create-theme/theme-locale.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,11 @@ private static function get_localizable_block_attributes( $block_name ) {
case 'core/comments-pagination-previous':
case 'core/comments-pagination-next':
case 'core/post-navigation-link':
case 'core/navigation-link':
case 'core/navigation-submenu':
case 'core/home-link':
case 'core/social-link':
case 'core/categories':
return array( 'label' );
case 'core/post-excerpt':
return array( 'moreText' );
Expand Down
25 changes: 25 additions & 0 deletions tests/CbtThemeLocale/escapeBlockAttributes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,31 @@ public function data_test_escape_block_attributes() {
'expected_markup' => '<!-- wp:post-navigation-link {"label":"<?php esc_attr_e(\'Custom Label\', \'test-locale-theme\');?>"} /-->',
),

'navigation-link with label' => array(
'block_markup' => '<!-- wp:navigation-link {"label":"About","url":"/about"} /-->',
'expected_markup' => '<!-- wp:navigation-link {"label":"<?php esc_attr_e(\'About\', \'test-locale-theme\');?>","url":"/about"} /-->',
),

'navigation-submenu with label' => array(
'block_markup' => '<!-- wp:navigation-submenu {"label":"Resources","url":"/resources"} /-->',
'expected_markup' => '<!-- wp:navigation-submenu {"label":"<?php esc_attr_e(\'Resources\', \'test-locale-theme\');?>","url":"/resources"} /-->',
),

'home-link with label' => array(
'block_markup' => '<!-- wp:home-link {"label":"Home"} /-->',
'expected_markup' => '<!-- wp:home-link {"label":"<?php esc_attr_e(\'Home\', \'test-locale-theme\');?>"} /-->',
),

'social-link with label' => array(
'block_markup' => '<!-- wp:social-link {"url":"https://example.com","service":"chain","label":"My website"} /-->',
'expected_markup' => '<!-- wp:social-link {"url":"https://example.com","service":"chain","label":"<?php esc_attr_e(\'My website\', \'test-locale-theme\');?>"} /-->',
),

'categories with label' => array(
'block_markup' => '<!-- wp:categories {"displayAsDropdown":true,"label":"Browse by topic"} /-->',
'expected_markup' => '<!-- wp:categories {"displayAsDropdown":true,"label":"<?php esc_attr_e(\'Browse by topic\', \'test-locale-theme\');?>"} /-->',
),

'search block with only some attributes' => array(
'block_markup' => '<!-- wp:search {"placeholder":"Search..."} /-->',
'expected_markup' => '<!-- wp:search {"placeholder":"<?php esc_attr_e(\'Search...\', \'test-locale-theme\');?>"} /-->',
Expand Down
Loading