Investigation: Alternative paths to fix macOS codesiging#30
Closed
mokagio wants to merge 1 commit into
Closed
Conversation
Keep the verification lane in place so Buildkite records the unsigned artifact failure before trying an alternative certificate setup. --- Generated with the help of Codex, https://openai.com/codex Co-Authored-By: Codex GPT-5 <noreply@openai.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears to investigate alternative approaches to the macOS code-signing fix introduced in PR #22 by removing the CI-only Apple intermediate certificate import from the Fastlane before_all hook.
Changes:
- Remove the CI-only download/import of Apple’s “Developer ID Certification Authority” G2 intermediate from
before_all. - Remove the now-unused
require 'tmpdir'.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
21
to
23
| before_all do |_lane| | ||
| setup_ci # Fixes Keychain access on CI | ||
|
|
||
| # macOS 26 CI images don't ship the "Developer ID Certification Authority" G2 | ||
| # intermediate, and `match` installs only the leaf. Without the intermediate in | ||
| # a search-list keychain, `security` can't build the chain and evaluates the | ||
| # identity as CSSMERR_TP_NOT_TRUSTED — electron-builder then silently skips | ||
| # signing. Install it into the temp keychain `setup_ci` just created. | ||
| if FastlaneCore::Helper.is_ci? | ||
| cert_path = File.join(Dir.tmpdir, 'DeveloperIDG2CA.cer') | ||
| sh('curl', '-fsSL', 'https://www.apple.com/certificateauthority/DeveloperIDG2CA.cer', '-o', cert_path) | ||
| import_certificate(certificate_path: cert_path, keychain_name: 'fastlane_tmp_keychain') | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #22, but tried to explore other options.