Upgrade Electron and bundled Node runtime - #40
Draft
ashfame wants to merge 1 commit into
Draft
Conversation
Member
Author
@mokagio Is this something you can help us with? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37.
This is a draft alternative to #38. Instead of retrying installs with Node engine checks relaxed, it updates the application runtime so current
wordpress-developdependencies run on a supported Node version.Changes
@wp-playground/clito 3.1.47 so its native filesystem dependency can be rebuilt for Electron 43.electron-builderto 26.15.3 and migrate the Windows signing options to its currentsigntoolOptionsschema.Why
Electron 32 bundles Node 20.18.1, while current
wordpress-developdependencies require^20.19.0 || ^22.13.0 || >=24and enforce that requirement withengine-strict. Upgrading the bundled runtime fixes the incompatibility without bypassing package engine declarations.Validation completed on Linux
npm cipassed on Ubuntu 24.04 with GCC 13 and Debian Trixie with GCC 14.npm testpassed: 13/13.npm run build:oncepassed.isomorphic-gitstack cloned currentwordpress-develop/trunk.wordpress-developcheckout installed 2,567 packages with its normalengine-strictsetting and no fallback.Draft validation goals
Buildkite should now tell us whether the updated native dependency, Electron packaging, Windows signing, and macOS signing/notarization work on the real platform agents. After green builds, the Windows and macOS artifacts still need a short launch and WordPress workflow smoke test.
The native dependency did not compile with GCC 12, but passed with GCC 13 and GCC 14. Linux builders therefore need Python,
make, and a modern C++ compiler.