Skip to content

Fix save lock control (length check on object) #11636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 2 commits into from
Nov 8, 2018
Merged

Fix save lock control (length check on object) #11636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d779cf8
Fix length check on object
glingener Nov 8, 2018
cfdc3b7
Editor: Correct state shape of tested post saving lock
aduth Nov 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/editor/src/store/selectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2056,7 +2056,7 @@ export function isPostLocked( state ) {
* @return {boolean} Is locked.
*/
export function isPostSavingLocked( state ) {
return state.postSavingLock.length > 0;
return Object.keys( state.postSavingLock ).length > 0;
}

/**
Expand Down
4 changes: 2 additions & 2 deletions packages/editor/src/store/test/selectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,7 +964,7 @@ describe( 'selectors', () => {
describe( 'isPostSavingLocked', () => {
it( 'should return true if the post has postSavingLocks', () => {
const state = {
postSavingLock: [ { 1: true } ],
postSavingLock: { example: true },
currentPost: {},
saving: {},
};
Expand All @@ -974,7 +974,7 @@ describe( 'selectors', () => {

it( 'should return false if the post has no postSavingLocks', () => {
const state = {
postSavingLock: [],
postSavingLock: {},
currentPost: {},
saving: {},
};
Expand Down