You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes: #13773
The custom className was not being applied on the latest comments block.
How has this been tested?
I added a latest comments block; I checked using the browser inspector that on the editor by default no class name is applied and no unrequired empty spaces exist on the class field. I published the post and repeated the same checks on the frontend.
I added a custom className to the block and verified it was applied on the editor and the frontend.
I removed the className and verified the className was removed, and no unrequired empty spaces were added.
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
It was challenging to test because when the Gutenberg plugin is installed with WordPress 5.0, we don't require packages/block-library/src/latest-comments/index.php and so this change doesn't appear. I manually applied the diff to the Core PHP files. Not sure how we can make this easier.
It was challenging to test because when the Gutenberg plugin is installed with WordPress 5.0, we don't require packages/block-library/src/latest-comments/index.php and so this change doesn't appear. I manually applied the diff to the Core PHP files. Not sure how we can make this easier.
I'm sorry for the trouble caused I should have referred this need in the PR description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #13773
The custom className was not being applied on the latest comments block.
How has this been tested?
I added a latest comments block; I checked using the browser inspector that on the editor by default no class name is applied and no unrequired empty spaces exist on the class field. I published the post and repeated the same checks on the frontend.
I added a custom className to the block and verified it was applied on the editor and the frontend.
I removed the className and verified the className was removed, and no unrequired empty spaces were added.