Try: Improve appearance of hover on colored backgrounds.#14501
Conversation
|
Two general ideas for dealing with the mismatched breadcrumbs:
Here's a screenshot of how option 2 might shake out: |
jasmussen
left a comment
There was a problem hiding this comment.
You're great. Dig all of this a lot.
I would note that we can actually treat these hover labels as tooltips, i.e. they don't have to appear quickly. They can take as long as a normal tooltip takes to appear, if we feel that could make them less intrusive. Not something necessary for this PR, but worth noting. Here's a little more: https://www.nngroup.com/articles/tooltip-guidelines/ — this one does suggest, however, that if we do treat this more like a tooltip, it should probably look like all other tooltips, which is an interesting thought experiment for a different day.
That is interesting. Thanks for sharing. I'll merge this as is, and think about modifying the tooltips separately. Thanks for the review! |

The current hover state uses solid colors. These work nicely in many cases, but can also end up clashing with the document background if the theme uses a non white/black background color. As initially discussed in #14145 (comment), switching to a color value that uses opacity could positively impact the appearance in these cases.
This PR switches the following color values to their closest opacity equivalents:
$light-gray-500to$dark-opacity-light-500$dark-gray-600to$light-opacity-light-400The main design issue to note is that the breadcrumb background colors are unchanged in this PR. This is required to ensure proper text contrast of the breadcrumb text. This eliminates a bit of the visual connection between the left border and the breadcrumb. It feels a little clumsy to me, and I'm not totally sold on this solution for that reason.
Screenshots (Light Backgrounds)
Screenshots (Dark Backgrounds)



