Rename section block to group by talldan · Pull Request #14920 · WordPress/gutenberg

talldan · 2019-04-11T08:30:18Z

Description

Closes #14898

Renames the Section block to Group.

How has this been tested?

Manual testing
Updated E2E tests

See also #13964 (comment) for further details on testing (but replace the word section with group in your mind).

Screenshots

Types of changes

Breaking change (but one that should be ok if it's merged before the next release)

Checklist:

My code is tested.
My code follows the WordPress code style.
My code follows the accessibility standards.
My code has proper inline documentation.
I've included developer documentation if appropriate.

talldan · 2019-04-11T08:35:32Z

@kjellr - I think you might have been working on some patches for themes so that they work with what was the section block. I suppose this change affects that and the classes will have to be renamed?

gziolo

It looks like a lot of work to rename a single block 😅

gziolo · 2019-04-11T09:40:45Z

 @import "./rss/editor.scss";
 @import "./search/editor.scss";
-@import "./section/editor.scss";
+@import "./group/editor.scss";


Can it be moved to be sorted alphabetically?

gziolo · 2019-04-11T09:41:06Z

 import * as rss from './rss';
 import * as search from './search';
-import * as section from './section';
+import * as group from './group';


Can it be moved to be sorted alphabetically?

gziolo · 2019-04-11T09:41:14Z

 	},
-	core__section: {
-		originalBlock: 'Section',
+	core__group: {


Can it be moved to be sorted alphabetically?

kjellr · 2019-04-11T12:44:32Z

@kjellr - I think you might have been working on some patches for themes so that they work with what was the section block. I suppose this change affects that and the classes will have to be renamed?

Yep, that's right. None of the patches have been merged in yet, so this is a great time to make the change. 🙂

gziolo

The block itself can be inserted into post properly 👍

chrisvanpatten · 2019-04-11T15:16:21Z

I love this. When I had taken my stab at the container block, this was the approach I was trying to take, along with the "Group" and "Ungroup" functionality. I think this makes so much sense, makes it more intuitive for users, and really opens the door for a better user experience!

gziolo · 2019-04-11T15:20:08Z

What it's confusing at the moment is that when you insert Group block, what you actually see is Paragraph block:

Can we at least do something like:

or what @mtias suggested in our private chat with reusing the bits of Block Navigation feature:

Those aren't final design proposals by any means 😃

aduth · 2019-04-11T15:38:06Z

What it's confusing at the moment is that when you insert Group block, what you actually see is Paragraph block:

To be clear, should we consider this a separate task from the rename itself happening here?

I expect the work from #14241 should help to improve the experience of the default block appender.

getdave · 2019-04-11T17:02:19Z

I expect the work from #14241 should help to improve the experience of the default block appender.

Indeed my work on core/section was exactly what prompted me to start work on the placeholder/appender PR. I very much recommend we utilise this in both core/group and core/column once I can get that branch merged.

getdave · 2019-04-11T17:03:21Z

I love this. When I had taken my stab at the container block, this was the approach I was trying to take, along with the "Group" and "Ungroup" functionality. I think this makes so much sense, makes it more intuitive for users, and really opens the door for a better user experience!

@chrisvanpatten Here's my first pass at "Group" #14908

gziolo · 2019-04-11T18:53:42Z

I was sharing my experience from testing. I didn’t mean it should block this PR 👍

aduth · 2019-04-11T19:14:19Z

I was sharing my experience from testing. I didn’t mean it should block this PR 👍

Do you know if there's a related issue for tracking these improvements? Is #9628 relevant?

gziolo · 2019-04-12T08:10:19Z

Do you know if there's a related issue for tracking these improvements? Is #9628 relevant?

I'm not 100 sure but I commented regardless :) I also cross-posted to #14935 to keep the discussion going.

getdave · 2019-04-12T09:02:53Z

Great to see this rename get done so quickly @talldan 👍

* Rename section block to group * Update transforms test for rename of section block to group * Alphabeticalize

Rename section block to group

383a359

talldan added [Type] Task Issues or PRs that have been broken down into an individual action to take [Block] Group Affects the Group Block (and row, stack and grid variants) labels Apr 11, 2019

talldan added this to the 5.5 (Gutenberg) milestone Apr 11, 2019

talldan requested review from Soean, aduth, ajitbohra, chrisvanpatten, gziolo, jorgefilipecosta, nerrad, noisysocks, notnownikki, ntwb and youknowriad as code owners April 11, 2019 08:30

talldan self-assigned this Apr 11, 2019

talldan requested review from getdave and kjellr April 11, 2019 08:32

talldan mentioned this pull request Apr 11, 2019

Renaming the new "Section" block to "Group" #14898

Closed

Update transforms test for rename of section block to group

79dda10

gziolo reviewed Apr 11, 2019

View reviewed changes

gziolo added [Priority] High Used to indicate top priority items that need quick attention [Release] Do Not Punt Used to indicate the issue or pull request must not be moved from the assigned milestone labels Apr 11, 2019

Alphabeticalize

09f7956

gziolo approved these changes Apr 11, 2019

View reviewed changes

aduth merged commit 0b93ad4 into master Apr 11, 2019

aduth deleted the update/rename-section-to-group branch April 11, 2019 17:39

gziolo mentioned this pull request Apr 12, 2019

Add light borders + padding to show the relationship between parent and child blocks. #14935

Closed

mchowning pushed a commit to mchowning/gutenberg that referenced this pull request Apr 15, 2019

Rename section block to group (WordPress#14920)

285cd07

* Rename section block to group * Update transforms test for rename of section block to group * Alphabeticalize

This was referenced Apr 15, 2019

Bump version number to 5.5.0-rc.1 #14981

Merged

Bump/5.5 #15011

Closed

Release/5.5 #15012

Closed

Bump plugin version to 5.5 #15013

Merged

kjellr mentioned this pull request Apr 22, 2019

Rename Section Block to Group Block WordPress/gutenberg-starter-theme#83

Merged

vindl mentioned this pull request Apr 26, 2019

[Experimental] Gutenberg diff: add plugin for cherry-picking new features Automattic/wp-calypso#32624

Closed

Conversation

talldan commented Apr 11, 2019

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

Uh oh!

talldan commented Apr 11, 2019

Uh oh!

gziolo left a comment

Choose a reason for hiding this comment

Uh oh!

gziolo Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

talldan Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

gziolo Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

talldan Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

gziolo Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

talldan Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

kjellr commented Apr 11, 2019

Uh oh!

gziolo left a comment

Choose a reason for hiding this comment

Uh oh!

chrisvanpatten commented Apr 11, 2019

Uh oh!

gziolo commented Apr 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aduth commented Apr 11, 2019

Uh oh!

getdave commented Apr 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

getdave commented Apr 11, 2019

Uh oh!

gziolo commented Apr 11, 2019

Uh oh!

aduth commented Apr 11, 2019

Uh oh!

gziolo commented Apr 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

getdave commented Apr 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gziolo commented Apr 11, 2019 •

edited

Loading

getdave commented Apr 11, 2019 •

edited

Loading

gziolo commented Apr 12, 2019 •

edited

Loading