Fix: Server side rendered blocks are not parsed on the widgets screen.#15414
Merged
jorgefilipecosta merged 1 commit intoMay 6, 2019
Conversation
jorgefilipecosta
added
[Type] Bug
jorgefilipecosta
requested review from
aduth,
gziolo and
youknowriad
as code owners
jorgefilipecosta
deleted the
fix/server-side-rendered-blocks-not-parsed-on-the-widgets-screen
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Server-side rendered blocks are not being correctly parsed on widgets screen making legacy widget blocks not load correctly on #15074.
The problem was that the server side block definitions were not being bootstrapped on the widgets page.
How has this been tested?
I went to the widgets page http://yah.local/wp-admin/admin.php?page=gutenberg-widgets.
I pasted
wp.blocks.parse('<!-- wp:latest-posts {"postsToShow":34,"displayPostDate":true} /-->');on the developer tools command line.I verified the attributes were correctly parsed on the return value.