Update docs for selectors & actions moved to block-editor#15424
Merged
Conversation
This is to avoid adding any symbols to the generated handbook docs just yet. We'll add them back when switching to the new system.
oandregal
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
mkaz,
noisysocks,
notnownikki,
talldan and
youknowriad
as code owners
| * @see resetBlocks in core/block-editor store. | ||
| */ | ||
| export const resetBlocks = getBlockEditorAction( 'resetBlocks' ); | ||
| /** |
Contributor
There was a problem hiding this comment.
These all look great but from a code standards/ bike sheddy perspective I just wonder if we should have newlines above all these, similar to how it'd be done in PHP doc?
chrisvanpatten
approved these changes
May 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #13088 we moved some actions and selectors to the block-editor package. This had the secondary effect of removing them from the handbook docs.
They'll be brought back to the handbook in #15421 but to avoid an immense PR difficult to review I'd like to merge this change first.
Test
Check that there are no changes in documentation just yet.