Fix next/previous links in handbook#15456
Conversation
oandregal
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
mkaz,
notnownikki and
youknowriad
as code owners
oandregal
added
[Type] Bug
chrisvanpatten
left a comment
chrisvanpatten
left a comment
There was a problem hiding this comment.
All the changes to the tooling code look good, just want to make sure we still target manifest-devhub.json for the moment, to avoid unintentional changes on the legacy handbook until the auto-updates are disabled and the bulk redirects are on.
| "slug": "theme-support", | ||
| "markdown_source": "https://raw.githubusercontent.com/WordPress/gutenberg/master/docs/designers-developers/developers/themes/theme-support.md", | ||
| "parent": "themes" | ||
| "title": "@wordpress/a11y", |
There was a problem hiding this comment.
The legacy manifest.json should not be changing at this point, so the legacy handbook isn't updated. Updated manifests should still be targeted at manifest-devhub.json until we can disable the auto-updates at the legacy handbook.
There was a problem hiding this comment.
Note that the changes merely reorder the sections to fix the previous/next links, do not alter anything else (titles, slug, etc). This can be safely merged, then the DevHub manifest PR can be rebased and updated to reflect these changes as well.
| const { getRootManifest } = require( './manifest' ); | ||
|
|
||
| const tocFileInput = path.resolve( __dirname, '../toc.json' ); | ||
| const manifestOutput = path.resolve( __dirname, '../manifest.json' ); |
There was a problem hiding this comment.
See note above re: manifest.json vs manifest-devhub.json
3 participants
Closes #14794
After landing #15421 the only outstanding issue for next/previous links were components and packages children. This fixes the issue by embedding the sections in the proper places.