Connnect gutenberg widgets screen to widget area endpoints#15779
Merged
jorgefilipecosta merged 10 commits intoMay 22, 2019
Merged
Conversation
jorgefilipecosta
added
[Type] Task
jorgefilipecosta
requested review from
aduth,
gziolo,
nerrad and
youknowriad
as code owners
youknowriad
approved these changes
May 22, 2019
jorgefilipecosta
deleted the
try/connetc-gutenberg-widgets-screen-to-widget-area-endpoints
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a store to keep the state in edit-widgets module, and connects the edit widgets screen to the widget-area endpoints being implemented in #15015.
It allows us to have PoC of the widget screen using blocks, covering the retrieving of legacy widgets, showing them and migrating the structure to blocks.
Legacy widgets are not working as expected because we have a bug on the widgets screen. The attributes of server-side rendered blocks are not correctly parsed in this screen.
If we paste wp.blocks.parse(''); on the console while the editor is open the attributes are correctly parsed on the gutenberg-widgets screen the attributes are not parsed.
This PR was discussed and approved in #15074. But I merged it to the wrong branch, as there is no way to reopen a merged PR I'm creating a second PR.