Only apply appender margins when the appender is inside of a block#15888
Merged
Conversation
talldan
approved these changes
May 30, 2019
Contributor
talldan
left a comment
There was a problem hiding this comment.
I wonder how this issue regressed 🤔
The fix works well, and it'd be nice to get it merged, as its one of those things that's a fairly apparent visual issue—something that many will notice during their first experience of the editor.
Only other thought is that it might be worth adding a comment explaining the additional class.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out by @jasmussen in #15868, the default appender for Twenty Nineteen appears improperly indented until it's clicked. After some investigation, I've determined that this is a side effect of the new(ish) margins added to the default appender in #14241.
In most themes, these margins are collapsed, so this has no effect. But they're visible in Twenty Nineteen, and push the placeholder text over:
This PR increases specificity of those margins so that they are put in place only when the default appender exists within an actual block. When it's outside of a block, those margins are unnecessary (I think?). This fixes the problem in Twenty Nineteen, and has no negative effects in any other theme I've tried.
Before:
Twenty Nineteen:
Gutenberg Starter Theme (Appears as expected):
After:
Twenty Nineteen:
Gutenberg Starter Theme (No change):