Block API: Downgrade convert API to experimental#16047
Merged
Merged
Conversation
aduth
added
[Feature] Block API
aduth
requested review from
Soean,
ajitbohra,
ellatrix,
gziolo,
jorgefilipecosta,
notnownikki,
talldan and
youknowriad
as code owners
2 tasks
nerrad
approved these changes
Jun 7, 2019
nerrad
approved these changes
Jun 7, 2019
Contributor
nerrad
left a comment
nerrad
left a comment
There was a problem hiding this comment.
Code wise looks fine. I'm unable to test to confirm the fix at the moment, but if needed I can do it later today.
Contributor
|
Good to see this. Probably safest given the uncertainty around naming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #15972, #14908
This pull request seeks to rename the
converttransform function introduced in #14908 to be marked as experimental (see relevant documentation), pending further consideration for how it be named or implemented.Testing Instructions:
Repeat Testing Instructions from #14908, verifying no regressions in the behavior of block grouping / ungrouping.