Skip to content

Ignore the wordpress directory in stylelint.#16243

Merged
pento merged 1 commit into
WordPress:masterfrom
desaiuditd:fix/ignore-wordpress-directory-in-style-linting
Aug 20, 2019
Merged

Ignore the wordpress directory in stylelint.#16243
pento merged 1 commit into
WordPress:masterfrom
desaiuditd:fix/ignore-wordpress-directory-in-style-linting

Conversation

@desaiuditd
Copy link
Copy Markdown
Member

@desaiuditd desaiuditd commented Jun 22, 2019

Description

While working in localwpdev mode in local environment, npm run lint-css does not ignore wordpress directory which works as a volume for the docker containers.

It throws errors as below:

[2] wordpress/wp-content/themes/twentynineteen/sass/site/primary/_comments.scss
[2]   87:25  ✖  Unexpected whitespace before ")"   function-parentheses-space-inside
[2]  174:22  ✖  Expected a leading zero            number-leading-zero
[2]  174:68  ✖  Unexpected whitespace before ")"   function-parentheses-space-inside
[2]  229:24  ✖  Unexpected whitespace after "("    function-parentheses-space-inside
[2]  229:41  ✖  Unexpected whitespace before ")"   function-parentheses-space-inside
[2]  235:48  ✖  Expected a leading zero            number-leading-zero
[2]  242:11  ✖  Unexpected named color "white"     color-named
[2]  369:21  ✖  Unexpected whitespace after "("    function-parentheses-space-inside
[2]  369:25  ✖  Unexpected whitespace before ")"   function-parentheses-space-inside
[2]  370:20  ✖  Expected a leading zero            number-leading-zero
[2]
[2] wordpress/wp-content/themes/twentynineteen/sass/site/primary/_posts-and-pages.scss
[2]   11:11  ✖  Expected a leading zero                         number-leading-zero
[2]  144:6   ✖  Expected double colon pseudo-element notation   selector-pseudo-element-colon-notation
[2]  149:15  ✖  Expected a leading zero                         number-leading-zero
[2]  162:5   ✖  Expected double colon pseudo-element notation   selector-pseudo-element-colon-notation
[2]  163:5   ✖  Expected double colon pseudo-element notation   selector-pseudo-element-colon-notation
[2]  168:12  ✖  Expected newline after ";"                      declaration-block-semicolon-newline-after
[2]  201:5   ✖  Expected double colon pseudo-element notation   selector-pseudo-element-colon-notation
[2]
[2] npm
[2]  ERR! code ELIFECYCLE
[2] npm
[2]  ERR! errno 2
[2] npm
[2]  ERR! gutenberg@5.9.2 lint-css: `wp-scripts lint-style '**/*.scss'`
[2] npm ERR! Exit status 2
[2] npm ERR!
[2] npm ERR! Failed at the gutenberg@5.9.2 lint-css script.
[2] npm ERR!
[2]  This is probably not a problem with npm. There is likely additional logging output above.
[2]
[2] npm ERR! A complete log of this run can be found in:
[2] npm ERR!     /Users/udit.desai/.npm/_logs/2019-06-22T07_11_57_444Z-debug.log
[2] npm run lint-css exited with code 2

wordpress directory should not be scanned and ignored for the linting purpose.

How has this been tested?

  • Running npm run lint-css in local environment does not report those errors anymore.
  • Local Environment: MacOS
  • This is only affected in linting the source code. No behavior change is expected.

Screenshots

Screen Shot 2019-06-22 at 17 21 14

Types of changes

  • Introduced .stylelintignore file at the project root and added wordpress directory in it to ignore.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@talldan talldan added [Type] Bug An existing feature does not function as intended [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Aug 20, 2019
Copy link
Copy Markdown
Member

@pento pento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into the same problem working on #17004! Let's merge this PR, I can rebase mine.

@pento pento changed the title Ignore wordpress directory in style lint while working in localwpdev mode Ignore the wordpress directory in stylelint. Aug 20, 2019
@pento pento merged commit 37d7dce into WordPress:master Aug 20, 2019
pento added a commit that referenced this pull request Aug 20, 2019
@desaiuditd desaiuditd deleted the fix/ignore-wordpress-directory-in-style-linting branch August 20, 2019 11:29
pento added a commit that referenced this pull request Aug 22, 2019
pento added a commit that referenced this pull request Aug 27, 2019
pento added a commit that referenced this pull request Aug 29, 2019
@gziolo
Copy link
Copy Markdown
Member

gziolo commented Sep 2, 2019

Related: #17296 which will enable it for all plugin developers as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants