Core Data: Return updated record in saveEntityRecord.#17030
Merged
Conversation
youknowriad
approved these changes
Aug 14, 2019
youknowriad
pushed a commit
that referenced
this pull request
Aug 14, 2019
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes
saveEntityRecordfromcore-datareturn the updated record like it did before #16867. Some plugins expect this behavior and the change was not backwards compatible.How has this been tested?
A test case was added for this behavior to avoid regressions.
Types of Changes
Bug Fix: Rollback breaking change of not returning the updated record in
saveEntityRecordfromcore-data.Checklist: