Skip to content

RichText: Fall back to setTimeout if no requestIdleCallback #17213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcsf merged 2 commits into from
Aug 27, 2019
Merged

RichText: Fall back to setTimeout if no requestIdleCallback #17213

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0217002
RichText: Fall back to requestAnimationFrame if no requestIdleCallback
mcsf Aug 27, 2019
97f4a57
Fall back to setTimeout(_, 100) if no requestIdleCallback
mcsf Aug 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/block-editor/src/components/rich-text/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ import FormatToolbar from './format-toolbar';
import { withBlockEditContext } from '../block-edit/context';
import { RemoveBrowserShortcuts } from './remove-browser-shortcuts';

const requestIdleCallback = window.requestIdleCallback ||
function fallbackRequestIdleCallback( fn ) {
window.setTimeout( fn, 100 );
};

const wrapperClasses = 'editor-rich-text block-editor-rich-text';
const classes = 'editor-rich-text__editable block-editor-rich-text__editable';

Expand Down Expand Up @@ -301,7 +306,7 @@ class RichTextWrapper extends Component {
* ensure all selection changes have been recorded.
*/
markAutomaticChange() {
window.requestIdleCallback( () => {
requestIdleCallback( () => {
this.props.markAutomaticChange();
} );
}
Expand Down