Skip to content

Fix file permissions in the Docker containers#17597

Closed
pento wants to merge 1 commit into
masterfrom
fix/docker-permissions
Closed

Fix file permissions in the Docker containers#17597
pento wants to merge 1 commit into
masterfrom
fix/docker-permissions

Conversation

@pento
Copy link
Copy Markdown
Member

@pento pento commented Sep 26, 2019

Description

WordPress/wpdev-docker-images#16 changed the Docker images to have more reliable file permissions. #17518 is in progress to take full advantage of this, but requires a bunch more work.

This PR helps avoid unnecessarily failing Travis tests in the mean time.

How has this been tested?

Compare a re-run of Travis on a recent merge to master (eg, https://travis-ci.com/WordPress/gutenberg/builds/129202271) to Travis on this PR.

@pento pento added [Type] Build Tooling Issues or PRs related to build tooling [Priority] Highest (OMGBBQ) Used to indicate widespread, critical issues that need immediate attention labels Sep 26, 2019
@pento pento self-assigned this Sep 26, 2019
@pento
Copy link
Copy Markdown
Member Author

pento commented Sep 26, 2019

This PR proved that Travis just needed the environment variables set.

As Travis always runs with both UID and GID of 2000, I've manually set that in the Travis web config, it can be removed sometime later.

@pento pento closed this Sep 26, 2019
@pento pento deleted the fix/docker-permissions branch September 26, 2019 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Priority] Highest (OMGBBQ) Used to indicate widespread, critical issues that need immediate attention [Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant